Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the REST specification #51791

Merged
merged 4 commits into from
Feb 2, 2020
Merged

Fixes for the REST specification #51791

merged 4 commits into from
Feb 2, 2020

Conversation

karmi
Copy link
Contributor

@karmi karmi commented Feb 2, 2020

This pull request backports commits e2a2169, c8b6a84, c1d9966 and 59f28f4 into the 7.x branch.

karmi added 4 commits February 2, 2020 10:06
…#51527)

The Get License API specifies the `accept_enterprise` parameter as a `boolean`:

https://github.com/elastic/elasticsearch/blob/0ca5cb8cb636a4be9c36b8e38e565af66abc423b/x-pack/plugin/src/test/resources/rest-api-spec/api/license.get.json#L22-L27

In the test, a `string` is passed however, which makes the test compilation fail in the Go client.

(cherry picked from commit e2a2169)
This patch fixes the SQL REST API documentation to conform to the current schema.

(cherry picked from commit c8b6a84)
…ecification (#51535)

This patch updates the `type` parameter in the Delete By Query API: according to
[the documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete-by-query.html#docs-delete-by-query-slice),
it can be set to "auto", but the type in the documentation allows only numerical values.

This prevents people from setting the parameter to "auto" eg. in the Go client,
which generates source from the specification, and sets the corresponding Go
type as number.

The patch uses the `|` notation, which we have discussed previously for encoding
a "polymorphic" parameter like this.

Related: elastic/go-elasticsearch#77
This patch fixes the REST API documentation for the Enrich APIs to conform to the current schema.

(cherry picked from commit 59f28f4)
@karmi
Copy link
Contributor Author

karmi commented Feb 2, 2020

The elasticsearch-ci/bwc build failed with:

java.lang.RuntimeException: Failure at [search/180_locale_dependent_mapping:8]: Connection is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant